New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redefine ExportSpans of SpanExporter with ReadOnlySpan #1873
Merged
Commits on Apr 30, 2021
-
-
Remove the Tracer method from the ReadOnlySpan
This is not required by the specification nor the use of this interface.
-
Use this type to encapsulate the Span status similar to the Event type encapsulating a Span event
-
Remove IsRecording from the ReadOnlySpan interface
A read-only span value does not need to know if updates to it will be recorded. It by definition cannot be updated so no point in communicating if an update would be recorded.
-
-
-
-
Update ReadOnlySpan interface with meta info methods
Add the DroppedAttributes, DroppedLinks, DroppedEvents, and ChildSpanCount methods to the interface to return additional information about the span not specified by the specification, but that we are already providing.
Commits on May 2, 2021
-
-
-
-
Remove Snapshot method from snapshot type
This method is a hold-over from previous version of the ReadOnlySpan interface is not needed.
-
Commits on May 3, 2021
Commits on May 4, 2021
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.