Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed different types of Detectors for Resources. #1810

Merged
merged 20 commits into from Apr 29, 2021
Merged

Removed different types of Detectors for Resources. #1810

merged 20 commits into from Apr 29, 2021

Commits on Apr 14, 2021

  1. Removed different types of Detectors for Resources. 

    This change simplifies different types of collectors into one list. The
order of this list determines how they are applied.  Defaults are
applied when the user does not supply any detectors.  To achieve
default behavior and additional behavior a DefaultDetectors struct has been
created
    @MadVikingGod
    MadVikingGod committed Apr 14, 2021
    Copy the full SHA
    8b2edde View commit details
    Browse the repository at this point in the history

  2. missed prometheus test.

    @MadVikingGod
    MadVikingGod committed Apr 14, 2021
    Copy the full SHA
    7ab5d43 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2021

  1. Changed behavior around WithDetectors(nil) 

    Added examples of use of WithDetectors.
    @MadVikingGod
    MadVikingGod committed Apr 15, 2021
    Copy the full SHA
    1b5330d View commit details
    Browse the repository at this point in the history

  2. Added NoOp example

    @MadVikingGod
    MadVikingGod committed Apr 15, 2021
    Copy the full SHA
    b48a6c3 View commit details
    Browse the repository at this point in the history

  3. Changed test to reflect acutal default case 

    This changes because WithDetector() no longer is the same as not using WithDetector()
    @MadVikingGod
    MadVikingGod committed Apr 15, 2021
    Copy the full SHA
    449a733 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2021

  1. Unexports the noOp detector

    @MadVikingGod
    MadVikingGod committed Apr 16, 2021
    Copy the full SHA
    7ee5d54 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2021

  1. Updated changelog

    @MadVikingGod
    MadVikingGod committed Apr 19, 2021
    Copy the full SHA
    5eb993e View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2021

  1. Fixes to spelling mistakes.

    @MadVikingGod
    MadVikingGod committed Apr 20, 2021
    Copy the full SHA
    5d59981 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into resource-new

    @MadVikingGod
    MadVikingGod committed Apr 20, 2021
    Copy the full SHA
    33691ee View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2021

  1. Merge remote-tracking branch 'upstream/main' into resource-new

    @MadVikingGod
    MadVikingGod committed Apr 21, 2021
    Copy the full SHA
    c52f70a View commit details
    Browse the repository at this point in the history

  2. Added NewEmptyResouce and unexported builtin detectors

    @MadVikingGod
    MadVikingGod committed Apr 21, 2021
    Copy the full SHA
    0bb0f87 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into resource-new

    @MadVikingGod
    MadVikingGod committed Apr 21, 2021
    Copy the full SHA
    5092fa5 View commit details
    Browse the repository at this point in the history

  4. Fix for prometheus example

    @MadVikingGod
    MadVikingGod committed Apr 21, 2021
    Copy the full SHA
    e403bd5 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2021

  1. Resource has two Rs 

    I need to get a new R key it seems.

Co-authored-by: Sam Xie <xsambundy@gmail.com>
    @MadVikingGod @XSAM
    MadVikingGod and XSAM committed Apr 22, 2021
    Copy the full SHA
    f531472 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2021

  1. Merge remote-tracking branch 'upstream/main' into resource-new

    @MadVikingGod
    MadVikingGod committed Apr 27, 2021
    Copy the full SHA
    2baf639 View commit details
    Browse the repository at this point in the history

  2. Replaced NewEmptyResource() with New()

    @MadVikingGod
    MadVikingGod committed Apr 27, 2021
    Copy the full SHA
    0c209da View commit details
    Browse the repository at this point in the history

  3. Fix test function name

    @MadVikingGod
    MadVikingGod committed Apr 27, 2021
    Copy the full SHA
    136d86b View commit details
    Browse the repository at this point in the history

  4. Comment fixups.

    @MadVikingGod
    MadVikingGod committed Apr 27, 2021
    Copy the full SHA
    e1b9b1a View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
    @MadVikingGod @MrAlias
    MadVikingGod and MrAlias committed Apr 28, 2021
    Copy the full SHA
    8e33b84 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2021

  1. Merge branch 'main' into resource-new

    @MrAlias
    MrAlias committed Apr 29, 2021
    Copy the full SHA
    c90ebc1 View commit details
    Browse the repository at this point in the history