New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Span.AddLink tests #5115
base: main
Are you sure you want to change the base?
Merge Span.AddLink tests #5115
Conversation
Signed-off-by: perhapsmaple <140232061+perhapsmaple@users.noreply.github.com>
I wonder if |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5115 +/- ##
=====================================
Coverage 83.7% 83.7%
=====================================
Files 252 252
Lines 16426 16458 +32
=====================================
+ Hits 13751 13778 +27
- Misses 2386 2389 +3
- Partials 289 291 +2 |
Signed-off-by: perhapsmaple <140232061+perhapsmaple@users.noreply.github.com>
Hi @dmathieu, I have added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test cases look good but need to be refactored for readability.
Co-authored-by: Sam Xie <sam@samxie.me>
Co-authored-by: Sam Xie <sam@samxie.me>
Signed-off-by: perhapsmaple <140232061+perhapsmaple@users.noreply.github.com>
Signed-off-by: perhapsmaple <140232061+perhapsmaple@users.noreply.github.com>
Co-authored-by: Sam Xie <sam@samxie.me>
Signed-off-by: perhapsmaple <140232061+perhapsmaple@users.noreply.github.com>
Fixes #5114
Refactored Span.AddLink tests into a single test