Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge both AddLink tests into one with subtests #5114

Open
dmathieu opened this issue Mar 27, 2024 · 0 comments · May be fixed by #5115
Open

Merge both AddLink tests into one with subtests #5114

dmathieu opened this issue Mar 27, 2024 · 0 comments · May be fixed by #5115

Comments

@dmathieu
Copy link
Member

dmathieu commented Mar 27, 2024 •
edited by pellared

Both this test and the one above are very similar. How about refactoring them into a single one with options, and use subtests?
https://go.dev/blog/subtests

Originally posted by @dmathieu in #5032 (comment)
@dmathieu dmathieu mentioned this issue Mar 27, 2024
Merged
4 tasks
@perhapsmaple perhapsmaple linked a pull request Mar 28, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merge Span.AddLink tests perhapsmaple/opentelemetry-go
1 participant
@dmathieu