Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the unused Resource field from the MeterProvider #3253

Merged
merged 2 commits into from Oct 3, 2022
Merged

Remove the unused Resource field from the MeterProvider #3253

merged 2 commits into from Oct 3, 2022

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Oct 2, 2022

No description provided.

@MrAlias MrAlias added pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics Skip Changelog PRs that do not require a CHANGELOG.md entry labels Oct 2, 2022
@MrAlias MrAlias added this to the Metric v0.32.2 milestone Oct 2, 2022
@codecov
Copy link

codecov bot commented Oct 2, 2022 •
edited

Codecov Report

Merging #3253 (5125880) into main (efdbe5a) will decrease coverage by 0.0%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3253     +/-   ##
=======================================
- Coverage   77.3%   77.3%   -0.1%     
=======================================
  Files        159     159             
  Lines      11184   11182      -2     
=======================================
- Hits        8653    8651      -2     
  Misses      2333    2333             
  Partials     198     198
Impacted Files Coverage Δ
sdk/metric/provider.go 100.0% <ø> (ø)
exporters/jaeger/jaeger.go 90.3% <0.0%> (-0.9%) ⬇️
sdk/trace/batch_span_processor.go 81.9% <0.0%> (+0.8%) ⬆️

@MrAlias MrAlias merged commit 3675379 into open-telemetry:main Oct 3, 2022
@MrAlias MrAlias deleted the rm-res-provider branch October 3, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole dashpole approved these changes

@MadVikingGod MadVikingGod MadVikingGod approved these changes

@jmacd jmacd Awaiting requested review from jmacd

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9 Aneurysm9 is a code owner

@evantorrie evantorrie Awaiting requested review from evantorrie evantorrie is a code owner

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@pellared pellared Awaiting requested review from pellared pellared is a code owner

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung hanyuancheung is a code owner

@dmathieu dmathieu Awaiting requested review from dmathieu dmathieu is a code owner

Assignees
No one assigned
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
Metric v0.32.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MrAlias @dashpole @MadVikingGod