Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in example/fib/app.go line:69 #2860

Merged

Conversation

Frapschen
Copy link
Contributor

@Frapschen Frapschen commented Apr 25, 2022

Fixes #2862

dev env:

  • system:win10
  • IDE:goland

Describe:

when I run the example of fib,the loop will be Breaked by the Fscanf().

the error message:

What Fibonacci number would you like to know:
10
Fibonacci(10) = 55
What Fibonacci number would you like to know: 
unexpected newline

Process finished with the exit code 1

Fix method:

append a "\n" to the param string in Fscanf().

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 25, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@dmathieu
Copy link
Member

dmathieu commented Apr 25, 2022

See #2644.

@Frapschen
Copy link
Contributor Author

ok, I have modified the "getting-started.md" file, which refers to #2644.

@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #2860 (dae5dec) into main (fdfc821) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2860   +/-   ##
=====================================
  Coverage   75.7%   75.7%           
=====================================
  Files        180     180           
  Lines      11818   11818           
=====================================
+ Hits        8949    8951    +2     
+ Misses      2636    2634    -2     
  Partials     233     233           
Impacted Files Coverage Δ
sdk/trace/batch_span_processor.go 81.1% <0.0%> (+0.9%) ⬆️

CHANGELOG.md Outdated Show resolved Hide resolved
@pellared pellared added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 25, 2022
@hanyuancheung
Copy link
Member

This PR is not needed because it is not a bug:
#2644
#2717
Close it.

@MadVikingGod
Copy link
Contributor

After testing this bug does affect windows powershell, see #2862.

I believe that this change will fix powershell and not adversely affect any other platform. If someone has the chance to test with a mac I would appreciate it.

@MadVikingGod MadVikingGod reopened this Apr 26, 2022
@MadVikingGod
Copy link
Contributor

I would also like to point out that the reason this PR should be considered while the first two PRs weren't is this description has enough information to reproduce.

We welcome both bug reports and PRs, but we need to know why a change should be made. If you start with a bug report before or at the same time as a PR then we can get the reasoning behind the change.

@MrAlias MrAlias linked an issue Apr 26, 2022 that may be closed by this pull request
@MrAlias
Copy link
Contributor

MrAlias commented Apr 26, 2022

@MadVikingGod are you able to verify this PR resolves #2862? I have verified this does not change the working behavior on a Linux system.

Copy link
Contributor

@MadVikingGod MadVikingGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this does fix the powershell, and it doesn't affect mac or windows linuxs

@MrAlias MrAlias merged commit d342bde into open-telemetry:main Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Fibonacci example exits unexpectedly on windows.
6 participants