run ResetForTest during cleanup #2754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
paivagustavo,
MadVikingGod,
pellared and
hanyuancheung
as code owners
|
This change is for an internal package, used only in internal tests. I don't think it requires a changelog entry. |
Codecov Report
@@ Coverage Diff @@
## main #2754 +/- ##
=====================================
Coverage 76.7% 76.7%
=====================================
Files 181 181
Lines 12176 12178 +2
=====================================
+ Hits 9346 9350 +4
+ Misses 2605 2603 -2
Partials 225 225
|
pellared
approved these changes
Mar 30, 2022
MadVikingGod
approved these changes
Mar 30, 2022
MrAlias
approved these changes
Mar 30, 2022
hanyuancheung
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows @pellared's suggestion in #2749 (comment).
Instead of calling
ResetForTestdirectly, it pass thetesting.TB, and make it callt.Cleanup, so we reset everything at the end of the test instead of its beginning.By calling cleanup, we will also still be resetting if the test triggers a panic.