Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/global imports testing #2783

Closed
aaronbee opened this issue Apr 12, 2022 · 0 comments · Fixed by #2786
Closed

internal/global imports testing #2783

aaronbee opened this issue Apr 12, 2022 · 0 comments · Fixed by #2786
Labels
bug Something isn't working

Comments

@aaronbee
Copy link

Description

go.opentelemetry.io/otel has a dependency on the standard library "testing" package. Any production binary that depends on otel will end up including the "testing" library, which is unnecessary bloat. This import was added in #2754 in internal/global/state.go.

Environment

  • OS: N/A
  • Architecture: N/A
  • Go Version: go1.17
  • opentelemetry-go version: v1.6.3

Steps To Reproduce

go list -deps go.opentelemetry.io/otel | grep '^testing$'

Expected behavior

Production packages should not import "testing".

@aaronbee aaronbee added the bug Something isn't working label Apr 12, 2022
@MrAlias MrAlias added this to the Release v1.7.0 milestone Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants