Add Go 1.18 to our supported versions. #2679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadVikingGod
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
paivagustavo,
pellared and
hanyuancheung
as code owners
dashpole
approved these changes
Mar 16, 2022
Aneurysm9
approved these changes
Mar 16, 2022
MrAlias
reviewed
Mar 16, 2022
pellared
approved these changes
Mar 16, 2022
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
MrAlias
approved these changes
Mar 17, 2022
XSAM
approved these changes
Mar 18, 2022
Co-authored-by: Robert Pająk <pellared@hotmail.com>
plantfansam
approved these changes
Mar 18, 2022
There was a problem hiding this comment.
LGTM. I believe this is the fix for the broken markdown check.
Codecov Report
@@ Coverage Diff @@
## main #2679 +/- ##
=====================================
Coverage 75.8% 75.8%
=====================================
Files 173 173
Lines 11684 11684
=====================================
+ Hits 8860 8864 +4
+ Misses 2614 2610 -4
Partials 210 210
|
MrAlias
reviewed
Mar 18, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds go 1.18 to our supported versions and starts the clock on our removal of go 1.16