Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdk/resource: honor OTEL_SERVICE_NAME in fromEnv resource detector #1969

Merged
merged 3 commits into from Jun 4, 2021
Merged

sdk/resource: honor OTEL_SERVICE_NAME in fromEnv resource detector #1969

merged 3 commits into from Jun 4, 2021

Conversation

Aneurysm9
Copy link
Member

Fixes #1968

@Aneurysm9
sdk/resource: honor OTEL_SERVICE_NAME in fromEnv resource detector
4ef4342 
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
@Aneurysm9 Aneurysm9 added this to In progress in OpenTelemetry Go RC via automation Jun 3, 2021
@Aneurysm9 Aneurysm9 added area:resources Part of OpenTelemetry resources pkg:SDK Related to an SDK package release:1.0.0-rc.1 labels Jun 3, 2021
@codecov
Copy link

codecov bot commented Jun 3, 2021 •
edited

Codecov Report

Merging #1969 (64a509b) into main (aed4580) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #1969   +/-   ##
=====================================
  Coverage   76.3%   76.3%           
=====================================
  Files        157     157           
  Lines       8358    8363    +5     
=====================================
+ Hits        6380    6385    +5     
  Misses      1723    1723           
  Partials     255     255
Impacted Files Coverage Δ
sdk/resource/env.go 100.0% <100.0%> (ø)

@Aneurysm9
go fmt is still my friend, even if I forget about it occasionally
c420bf8 
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
OpenTelemetry Go RC automation moved this from In progress to Reviewer approved Jun 3, 2021
MrAlias
MrAlias reviewed Jun 4, 2021
View reviewed changes
sdk/resource/env.go Outdated Show resolved Hide resolved
@Aneurysm9
Fix import ordering
64a509b 
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
@MrAlias MrAlias merged commit a75ade4 into open-telemetry:main Jun 4, 2021
OpenTelemetry Go RC automation moved this from Reviewer approved to Done Jun 4, 2021
@Aneurysm9 Aneurysm9 mentioned this pull request Jun 17, 2021
Merged
@pellared pellared mentioned this pull request Jul 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAlias MrAlias MrAlias approved these changes

@dashpole dashpole dashpole approved these changes

@evantorrie evantorrie evantorrie approved these changes

@jmacd jmacd Awaiting requested review from jmacd

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod MadVikingGod is a code owner

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

Assignees
No one assigned
Labels
area:resources Part of OpenTelemetry resources pkg:SDK Related to an SDK package
Projects
No open projects
OpenTelemetry Go RC
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable Resource service.name detection from OTEL_SERVICE_NAME environment variable
4 participants
@Aneurysm9 @dashpole @MrAlias @evantorrie