add resource and scope to opencensus metric bridge

open-telemetry · Sep 19, 2022 · 8d8ac9f · 8d8ac9f
1 parent 164fcb4
commit 8d8ac9f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/bridge/opencensus/go.mod b/bridge/opencensus/go.mod
@@ -6,7 +6,7 @@ require (
 	go.opencensus.io v0.23.0
 	go.opentelemetry.io/otel v1.10.0
 	go.opentelemetry.io/otel/metric v0.32.0
-	go.opentelemetry.io/otel/sdk v0.0.0-00010101000000-000000000000
+	go.opentelemetry.io/otel/sdk v1.10.0
 	go.opentelemetry.io/otel/sdk/metric v0.32.0
 	go.opentelemetry.io/otel/trace v1.10.0
 )

diff --git a/bridge/opencensus/metric.go b/bridge/opencensus/metric.go
@@ -24,6 +24,7 @@ import (
 	"go.opencensus.io/metric/metricexport"
 
 	internal "go.opentelemetry.io/otel/bridge/opencensus/internal/ocmetric"
+	"go.opentelemetry.io/otel/sdk/instrumentation"
 	"go.opentelemetry.io/otel/sdk/metric"
 	"go.opentelemetry.io/otel/sdk/metric/metricdata"
 	"go.opentelemetry.io/otel/sdk/resource"
@@ -33,11 +34,12 @@ import (
 // OpenTelemetry base exporter.
 type exporter struct {
 	base metric.Exporter
+	res  *resource.Resource
 }
 
 // NewMetricExporter returns an OpenCensus exporter that exports to an
 // OpenTelemetry exporter.
-func NewMetricExporter(base metric.Exporter) metricexport.Exporter {
+func NewMetricExporter(base metric.Exporter, res *resource.Resource) metricexport.Exporter {
 	return &exporter{base: base}
 }
 
@@ -49,8 +51,13 @@ func (e *exporter) ExportMetrics(ctx context.Context, ocmetrics []*ocmetricdata.
 		return err
 	}
 	return e.base.Export(ctx, metricdata.ResourceMetrics{
-		Resource: resource.NewSchemaless(),
+		Resource: e.res,
 		ScopeMetrics: []metricdata.ScopeMetrics{
-			{Metrics: otelmetrics},
+			{
+				Scope: instrumentation.Scope{
+					Name: "go.opentelemetry.io/otel/bridge/opencensus",
+				},
+				Metrics: otelmetrics,
+			},
 		}})
 }