Skip to content

Commit

Permalink
test: --20220112 fix histogram instrument unit test (#2507)
Browse files Browse the repository at this point in the history
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
  • Loading branch information
3 people committed Mar 23, 2022
1 parent 07ad32d commit 3dac50a
Showing 1 changed file with 53 additions and 3 deletions.
56 changes: 53 additions & 3 deletions exporters/otlp/otlpmetric/exporter_test.go
Expand Up @@ -225,9 +225,9 @@ func TestNoGroupingExport(t *testing.T) {
)
}

func TestHistogramMetricGroupingExport(t *testing.T) {
func TestHistogramInt64MetricGroupingExport(t *testing.T) {
r := record(
"histogram",
"int64-histogram",
sdkapi.HistogramInstrumentKind,
number.Int64Kind,
append(baseKeyValues, cpuKey.Int(1)),
Expand All @@ -240,7 +240,7 @@ func TestHistogramMetricGroupingExport(t *testing.T) {
{
Metrics: []*metricpb.Metric{
{
Name: "histogram",
Name: "int64-histogram",
Data: &metricpb.Metric_Histogram{
Histogram: &metricpb.Histogram{
AggregationTemporality: metricpb.AggregationTemporality_AGGREGATION_TEMPORALITY_CUMULATIVE,
Expand Down Expand Up @@ -275,6 +275,56 @@ func TestHistogramMetricGroupingExport(t *testing.T) {
runMetricExportTests(t, nil, resource.Empty(), []testRecord{r, r}, expected)
}

func TestHistogramFloat64MetricGroupingExport(t *testing.T) {
r := record(
"float64-histogram",
sdkapi.HistogramInstrumentKind,
number.Float64Kind,
append(baseKeyValues, cpuKey.Int(1)),
testLibName,
)
expected := []*metricpb.ResourceMetrics{
{
Resource: nil,
InstrumentationLibraryMetrics: []*metricpb.InstrumentationLibraryMetrics{
{
Metrics: []*metricpb.Metric{
{
Name: "float64-histogram",
Data: &metricpb.Metric_Histogram{
Histogram: &metricpb.Histogram{
AggregationTemporality: metricpb.AggregationTemporality_AGGREGATION_TEMPORALITY_CUMULATIVE,
DataPoints: []*metricpb.HistogramDataPoint{
{
Attributes: cpu1Labels,
StartTimeUnixNano: startTime(),
TimeUnixNano: pointTime(),
Count: 2,
Sum: 11.0,
ExplicitBounds: testHistogramBoundaries,
BucketCounts: []uint64{1, 0, 0, 1},
},
{
Attributes: cpu1Labels,
Count: 2,
Sum: 11.0,
ExplicitBounds: testHistogramBoundaries,
BucketCounts: []uint64{1, 0, 0, 1},
StartTimeUnixNano: startTime(),
TimeUnixNano: pointTime(),
},
},
},
},
},
},
},
},
},
}
runMetricExportTests(t, nil, resource.Empty(), []testRecord{r, r}, expected)
}

func TestCountInt64MetricGroupingExport(t *testing.T) {
r := record(
"int64-count",
Expand Down

0 comments on commit 3dac50a

Please sign in to comment.