Skip to content

Commit

Permalink
fix for review
Browse files Browse the repository at this point in the history
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
  • Loading branch information
fatsheep9146 committed Nov 25, 2022
1 parent f7af1c0 commit 3c84770
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions exporters/prometheus/exporter.go
Expand Up @@ -392,17 +392,14 @@ func validateMetrics(name, description string, metricType *dto.MetricType, mfs m
}
return false, ""
}

if emf.GetHelp() != description {
if emf.GetType() == dto.MetricType_HISTOGRAM || *metricType == dto.MetricType_HISTOGRAM {
return false, ""
}
return false, emf.GetHelp()
}

if emf.GetType() != *metricType {
return true, ""
}

return false, ""
}

0 comments on commit 3c84770

Please sign in to comment.