Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: add yaml/json struct tags #5433

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

codeboten
Copy link
Contributor

This will make parsing the configuration easier

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 139 lines in your changes are missing coverage. Please review.

Project coverage is 62.4%. Comparing base (f251adc) to head (772047e).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #5433   +/-   ##
=====================================
  Coverage   62.4%   62.4%           
=====================================
  Files        189     189           
  Lines      11638   11638           
=====================================
  Hits        7263    7263           
  Misses      4158    4158           
  Partials     217     217           
Files Coverage Δ
config/generated_config.go 0.0% <0.0%> (ø)

@MadVikingGod
Copy link
Contributor

This needs a changelog.

I see this adds additional tags, but I'm not 100% sure how this is used. It doesn't necessarily need to be part of the PR, but could you share an example of how this was used before and how it works now?

@pellared
Copy link
Member

pellared commented May 7, 2024

Can you add tests that verify that the YAML/JSON files are parsed (thanks to the tags) as expected?

@codeboten
Copy link
Contributor Author

@MadVikingGod @pellared happy to add some functionality to test it, i didn't want to overstep on this PR #4826

@carrbs if you're ok with it I can incorporate your work here, or you can pull this change in your PR, it's all the same to me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants