HTTP Semconv migration Part3 Server - v1.24.0 support #5401
Conversation
MadVikingGod
requested review from
Aneurysm9,
dmathieu and
a team
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5401 +/- ##
=======================================
+ Coverage 62.3% 62.5% +0.1%
=======================================
Files 189 190 +1
Lines 11575 11673 +98
=======================================
+ Hits 7221 7296 +75
- Misses 4145 4161 +16
- Partials 209 216 +7
|
MadVikingGod
added
the
Skip Changelog
|
Changelog will be part of follow on PR as part of #5331 |
| // If the primary server name is not known, server should be an empty string. | ||
| // The req Host will be used to determine the server instead. | ||
| func (n newHTTPServer) RequestTraceAttrs(server string, req *http.Request) []attribute.KeyValue { | ||
| const MaxAttributes = 11 |
There was a problem hiding this comment.
| const MaxAttributes = 11 | |
| const maxAttributes = 11 |
There was a problem hiding this comment.
This is likely going to over allocate. Can we pre-determine the correct size or have an issue to track doing so later?
| } else { | ||
| // Prioritize the primary server name. | ||
| host, p = splitHostPort(server) | ||
| if p < 0 { |
There was a problem hiding this comment.
| if p < 0 { | |
| if host == "" && p < 0 { |
| // The req Host will be used to determine the server instead. | ||
| func (n newHTTPServer) RequestTraceAttrs(server string, req *http.Request) []attribute.KeyValue { | ||
| const MaxAttributes = 11 | ||
| attrs := make([]attribute.KeyValue, MaxAttributes) |
There was a problem hiding this comment.
| attrs := make([]attribute.KeyValue, MaxAttributes) | |
| attrs := make([]attribute.KeyValue, 0, MaxAttributes) |
Tracking append position could then be replaced with append
| attrs[0] = semconvNew.HTTPRequestMethodGet | ||
| } | ||
| attrs[1] = semconvNew.HTTPRequestMethodOriginal(method) | ||
| return 2 |
There was a problem hiding this comment.
The index state is not tracked with a variable. This is going to be brittle and tough to evolve.
|
|
||
| func (n newHTTPServer) method(method string, attrs []attribute.KeyValue) int { | ||
| if method == "" { | ||
| attrs[0] = semconvNew.HTTPRequestMethodGet |
There was a problem hiding this comment.
It is not obvious that attrs passed here has to be pre-allocated.
Using an append approach would avoid the panic if len(attrs) <= 0.
| // | ||
| // If any of the fields in the ResponseTelemetry are not set the attribute will be omitted. | ||
| func (n newHTTPServer) ResponseTraceAttrs(resp ResponseTelemetry) []attribute.KeyValue { | ||
| attributes := []attribute.KeyValue{} |
There was a problem hiding this comment.
The allocation strategy is not the same as RequestTraceAttrs.
| if attr, ok := methodLookup[strings.ToUpper(method)]; ok { | ||
| attrs[0] = attr | ||
| } else { | ||
| // If the Original methos is not a standard HTTP method fallback to GET |
There was a problem hiding this comment.
| // If the Original methos is not a standard HTTP method fallback to GET | |
| // If the Original method is not a standard HTTP method fallback to GET |
| resp: ResponseTelemetry{ | ||
| StatusCode: 200, | ||
| ReadBytes: 701, | ||
| ReadError: fmt.Errorf("read error"), |
There was a problem hiding this comment.
| ReadError: fmt.Errorf("read error"), | |
| ReadError: errors.New("read error"), |
This change adds the new semantic version (v1.24.0) attribute producer to the semconv of otlehttp.
The full PR is #5092
Part of #5331