Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logrus logging bridge #5356

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Apr 3, 2024

Closes #5193.

This adds the logrus log bridge

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 99.05660% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 62.7%. Comparing base (cf0af93) to head (2eed62c).

❗ Current head 2eed62c differs from pull request most recent head 5727812. Consider uploading reports for the commit 5727812 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #5356     +/-   ##
=======================================
- Coverage   62.7%   62.7%   -0.1%     
=======================================
  Files        192     191      -1     
  Lines      11786   11752     -34     
=======================================
- Hits        7399    7374     -25     
+ Misses      4170    4161      -9     
  Partials     217     217             
Files Coverage Δ
bridges/otellogrus/hook.go 99.0% <99.0%> (ø)

... and 7 files with indirect coverage changes

@dmathieu dmathieu marked this pull request as ready for review April 10, 2024 12:56
@dmathieu dmathieu changed the title WIP: logrus logging bridge logrus logging bridge Apr 11, 2024
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to increase the test coverage.

In my opinion we should also add a test example. It may help not only the users but also other reviewers to understand how it is supposed to be used.

It would be good to add benchmarks, but this would be better added as a separate PR. I do not think it is a must-have given that logrus is not used in performance-critical applications.

bridges/otellogrus/go.mod Outdated Show resolved Hide resolved
bridges/otellogrus/hook.go Outdated Show resolved Hide resolved
bridges/otellogrus/hook.go Outdated Show resolved Hide resolved
bridges/otellogrus/hook.go Outdated Show resolved Hide resolved
bridges/otellogrus/hook.go Outdated Show resolved Hide resolved
bridges/otellogrus/hook.go Show resolved Hide resolved
bridges/otellogrus/hook_test.go Outdated Show resolved Hide resolved
bridges/otellogrus/hook_test.go Outdated Show resolved Hide resolved
CODEOWNERS Show resolved Hide resolved
bridges/otellogrus/hook.go Outdated Show resolved Hide resolved
bridges/otellogrus/hook.go Show resolved Hide resolved
bridges/otellogrus/hook.go Show resolved Hide resolved
bridges/otellogrus/hook.go Outdated Show resolved Hide resolved
bridges/otellogrus/hook_test.go Show resolved Hide resolved
bridges/otellogrus/go.mod Outdated Show resolved Hide resolved
bridges/otellogrus/hook.go Outdated Show resolved Hide resolved
@pellared
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add logrus log bridge
5 participants