New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
autoexport: Add OTEL_METRICS_PRODUCERS environment variable support #5281
autoexport: Add OTEL_METRICS_PRODUCERS environment variable support #5281
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5281 +/- ##
=====================================
Coverage 62.3% 62.4%
=====================================
Files 189 189
Lines 11575 11638 +63
=====================================
+ Hits 7219 7263 +44
- Misses 4146 4158 +12
- Partials 210 217 +7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gouthamve thanks for this! It will need an entry in CHANGELOG.md
Thanks for your review @dashpole! Anything I can do to move this along @open-telemetry/go-approvers? |
@gouthamve Sorry for the delay. I will do my best to review it this week. |
afc9715
to
1ee0485
Compare
Thanks for the review @pellared. I did the easiest thing here and exposed the Also, this seems a little counter-intuitive to me. We are using the same |
b7e8cda
to
9f01a62
Compare
9f01a62
to
93900a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
implementation looks correct to me.
1155097
to
faf3f01
Compare
bce3445
to
d1eda11
Compare
b2d37af
to
f3168b9
Compare
Signed-off-by: Goutham <gouthamve@gmail.com> Signed-off-by: gouthamve <gouthamve@gmail.com> Add tests for Prometheus producer Signed-off-by: gouthamve <gouthamve@gmail.com>
Signed-off-by: gouthamve <gouthamve@gmail.com>
Signed-off-by: gouthamve <gouthamve@gmail.com>
Signed-off-by: gouthamve <gouthamve@gmail.com> Signed-off-by: Goutham <gouthamve@gmail.com>
Signed-off-by: Goutham <gouthamve@gmail.com>
Signed-off-by: Goutham <gouthamve@gmail.com>
Signed-off-by: Goutham <gouthamve@gmail.com>
Signed-off-by: Goutham <gouthamve@gmail.com>
10c14b1
to
b049186
Compare
Currently blocked on open-telemetry/opentelemetry-go-contrib#5281 Signed-off-by: Goutham <gouthamve@gmail.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com> Signed-off-by: gouthamve <gouthamve@gmail.com>
cee6b6c
to
4e3ac55
Compare
This will allow using the Prometheus bridge with autoexport.
The goal is to make it easy for any Prometheus exporter to also be able to emit OTLP. See: https://prometheus.io/blog/2024/03/14/commitment-to-opentelemetry/#otlp-export-in-the-ecosystem