New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
otelgrpc: Add Filter for stats handler #5196
Conversation
4a4eb3e
to
3203812
Compare
instrumentation/google.golang.org/grpc/otelgrpc/filters/interceptor/filters.go
Show resolved
Hide resolved
lgtm overall. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5196 +/- ##
=======================================
+ Coverage 62.5% 62.7% +0.1%
=======================================
Files 191 192 +1
Lines 11727 11786 +59
=======================================
+ Hits 7340 7399 +59
Misses 4170 4170
Partials 217 217
|
Any update if this will be reviewed in order to be merged? |
@dashpole @hanyuancheung |
Overall LGTM, just little comments that I think it would be nice to address before merging. |
instrumentation/google.golang.org/grpc/otelgrpc/filters/interceptor/filters.go
Show resolved
Hide resolved
instrumentation/google.golang.org/grpc/otelgrpc/filters/interceptor/filters.go
Outdated
Show resolved
Hide resolved
instrumentation/google.golang.org/grpc/otelgrpc/filters/interceptor/filters.go
Outdated
Show resolved
Hide resolved
instrumentation/google.golang.org/grpc/otelgrpc/filters/filters.go
Outdated
Show resolved
Hide resolved
LGTM, but there are some comments that should be addressed.
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
@dashpole, can you please make another review and possibly merge if you find everything good? |
Hey thanks! |
Description
Add filter for stats handler and move interceptor filter to
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc/filters/interceptor
considering that it'll be deprecated.Related Issue
Fixes #4575
Test
Unit tests added.
And I've tested on: https://github.com/grpc/grpc-go/tree/master/examples/route_guide
No filters
Method name filter