Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

otelhttptrace: handle missing getconn hook without panic #5187

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Open

otelhttptrace: handle missing getconn hook without panic #5187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions instrumentation/net/http/httptrace/otelhttptrace/clienttrace.go
View file
Open in desktop
Expand Up @@ -226,6 +226,10 @@

func (ct *clientTracer) end(hook string, err error, attrs ...attribute.KeyValue) {
if !ct.useSpans {
// sometimes end may be called without previous start
if ct.root == nil {
ct.root = trace.SpanFromContext(ct.Context)
}

Check warning on line 232 in instrumentation/net/http/httptrace/otelhttptrace/clienttrace.go

View check run for this annotation

Codecov / codecov/patch

instrumentation/net/http/httptrace/otelhttptrace/clienttrace.go#L231-L232 

Added lines #L231 - L232 were not covered by tests
if err != nil {
attrs = append(attrs, attribute.String(hook+".error", err.Error()))
}
Expand Down