chore: update jaeger remote sampler example #4892
Conversation
hcelaloner
force-pushed
the
chore/update-jaegerremote-example
branch
from
009fc0b
to
27a499a
Compare
CHANGELOG.md
Outdated
| @@ -21,6 +21,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm | |||
| ### Fixed | |||
|
|
|||
| - Do not panic in `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc` if `MeterProvider` returns a `nil` instrument. (#4875) | |||
| - OpenTelemetry Collector based example for `go.opentelemetry.io/contrib/samplers/jaegerremote`. (#4892) | |||
There was a problem hiding this comment.
A Fixed entry would be a bugfix, which this isn't. How about moving it to the Changed section?
Also, how about something along the lines of:
Updated jaeger version in
go.opentelemetry.io/contrib/samplers/jaegerremote/exampleexample. (#4892)
There was a problem hiding this comment.
Thank you for the feedback. I also had some doubts about where should I add it while adding it to changelog. Of course 👍 I am going to move it in a minute.
…or extension Previously, example was outdated and not working properly. This commit updates the example provided using otelcol-contrib jaegerremotesampling extension.
hcelaloner
force-pushed
the
chore/update-jaegerremote-example
branch
from
27a499a
to
7c6e086
Compare
| @@ -27,12 +30,19 @@ import ( | |||
| ) | |||
|
|
|||
| func main() { | |||
| // Optional: an implementation of logr.Logger used for demo purposes to catch potential error logs | |||
| logger := stdr.NewWithOptions(stdlog.New(os.Stderr, "", stdlog.LstdFlags), stdr.Options{LogCaller: stdr.All}) | |||
There was a problem hiding this comment.
The addition of this logger is also more than just an update. Wouldn't that be adding quite a bit of noise in the output, making the example less readable?
There was a problem hiding this comment.
When I wanted to try the example, I couldn't see any error logs from the background updater. By default sampler was using logr.Discard() if I am not wrong, I just added to a simple stdout logr implementation to be able to check error logs while trying. I didn't remove it because I thought that it could be a nice for example.
Co-authored-by: Damien Mathieu <42@dmathieu.com>
chore: update jaeger remote sampler example using the latest otelcol-contrib extension
Previously, the example was outdated and not working properly. This commit updates the example provided using otelcol-contrib jaegerremotesampling extension.