Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disables context-as-argument linter #2878

Merged
merged 2 commits into from Feb 27, 2023

Conversation

MadVikingGod
Copy link
Contributor

This is currently incompatible with viper v1.13.0. Status for the linter found at golangci/golangci-lint#3280

This should unblock #2839

This is currently incompatible with viper v1.13.0. Status for the linter found at
golangci/golangci-lint#3280
@MadVikingGod MadVikingGod added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Oct 20, 2022
@MrAlias
Copy link
Contributor

MrAlias commented Oct 20, 2022

link to #2877

@MrAlias
Copy link
Contributor

MrAlias commented Feb 27, 2023

Blocking #3505

@MrAlias MrAlias requested a review from a team as a code owner February 27, 2023 18:41
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #2878 (f8c3563) into main (ce63dac) will decrease coverage by 0.6%.
The diff coverage is n/a.

❗ Current head f8c3563 differs from pull request most recent head 1abd7dd. Consider uploading reports for the commit 1abd7dd to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2878     +/-   ##
=======================================
- Coverage   69.9%   69.3%   -0.6%     
=======================================
  Files        147     145      -2     
  Lines       6934    6729    -205     
=======================================
- Hits        4848    4667    -181     
+ Misses      1961    1948     -13     
+ Partials     125     114     -11     
Impacted Files Coverage Δ
instrumentation/net/http/otelhttp/wrap.go 50.0% <0.0%> (-25.0%) ⬇️
detectors/aws/lambda/detector.go 89.4% <0.0%> (-3.4%) ⬇️
...ation/github.com/gin-gonic/gin/otelgin/gintrace.go 80.7% <0.0%> (-2.8%) ⬇️
instrumentation/net/http/otelhttp/config.go 80.3% <0.0%> (-2.6%) ⬇️
samplers/jaegerremote/sampler_remote.go 87.4% <0.0%> (-2.3%) ⬇️
instrumentation/net/http/otelhttp/handler.go 81.3% <0.0%> (-1.3%) ⬇️
...trumentation/github.com/gorilla/mux/otelmux/mux.go 86.2% <0.0%> (-1.0%) ⬇️
...tation/github.com/astaxie/beego/otelbeego/beego.go 85.5% <0.0%> (-0.2%) ⬇️
...entation/github.com/labstack/echo/otelecho/echo.go 95.0% <0.0%> (-0.2%) ⬇️
instrumentation/host/host.go 0.0% <0.0%> (ø)
... and 16 more

@MrAlias
Copy link
Contributor

MrAlias commented Feb 27, 2023

/easycla

@MrAlias MrAlias merged commit 41b319f into open-telemetry:main Feb 27, 2023
@MadVikingGod MadVikingGod deleted the mvg/disable-ctx-as-arg branch February 27, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants