Removed unneccessary renames for gocql #2795
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadVikingGod
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
pellared,
hanyuancheung and
dmathieu
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2795 +/- ##
=======================================
+ Coverage 69.2% 74.6% +5.4%
=======================================
Files 145 7 -138
Lines 6729 316 -6413
=======================================
- Hits 4661 236 -4425
+ Misses 1952 67 -1885
+ Partials 116 13 -103 |
MrAlias
reviewed
Sep 22, 2022
| @@ -203,7 +195,7 @@ func initMetrics() error { | |||
| http.Handle("/", promhttp.Handler()) | |||
| log.Print("Serving metrics at :2222/") | |||
There was a problem hiding this comment.
Suggested change
| log.Print("Serving metrics at :2222/") | |
| log.Print("Serving metrics at :2223/") |
There was a problem hiding this comment.
The README.md also needs updating if this is changing.
Comment on lines
132
to
134
| v, err := view.New( | ||
| view.MatchInstrumentName("db.cassandra.queries"), | ||
| view.WithRename("db_cassandra_queries"), | ||
| ) |
There was a problem hiding this comment.
These "blank action" views could be unified into a single view that matches "*"
|
This will fix the first set of changes in #2796 |
|
Closing in favor of #2960. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Release of metrics v0.32.1 means that the prometheus names are automatically renamed. This change removes unnecessary renames.
Blocked by open-telemetry/opentelemetry-go#3228, and release.