instrumentation/otelgrpc: rename Typ to Type #2688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zchee
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
|
cc: @ymotongpoo |
Typ is not a reserved name. Use the correct name instead of. Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
zchee
force-pushed
the
otelgrpc-rename-to-type
branch
from
baffe55
to
6514965
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2688 +/- ##
=======================================
- Coverage 74.4% 74.3% -0.1%
=======================================
Files 145 145
Lines 6685 6685
=======================================
- Hits 4974 4971 -3
- Misses 1564 1566 +2
- Partials 147 148 +1
|
|
Can you fix the lint issue? Also, this is changing a public attribute. So it will require a changelog entry. |
|
will do, thanks |
Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
|
@dmathieu PTAL. |
pellared
approved these changes
Aug 29, 2022
dmathieu
approved these changes
Aug 29, 2022
dashpole
approved these changes
Aug 29, 2022
MrAlias
reviewed
Aug 29, 2022
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
|
@MrAlias PTALA. |
MrAlias
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typis not a reserved name. Use the correct name instead of.