Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement aws.ecs.* resource attributes #2626

Merged
merged 11 commits into from Nov 23, 2022
Merged

Implement aws.ecs.* resource attributes #2626

merged 11 commits into from Nov 23, 2022

Commits on Oct 23, 2022

  1. Implemented aws.ecs.* resource attributes in go.opentelemetry.io/dete… 

    …ctors/aws/ecs
    Michele Mancioppi committed Oct 23, 2022
    Copy the full SHA
    9d8be4e View commit details
    Browse the repository at this point in the history

  2. Update detectors/aws/ecs/ecs_test.go 

    Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
    @hanyuancheung
    Michele Mancioppi and hanyuancheung committed Oct 23, 2022
    Copy the full SHA
    6a1b274 View commit details
    Browse the repository at this point in the history

  3. Update detectors/aws/ecs/ecs_test.go 

    Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
    @hanyuancheung
    Michele Mancioppi and hanyuancheung committed Oct 23, 2022
    Copy the full SHA
    8b5d348 View commit details
    Browse the repository at this point in the history

  4. fix: lower-case the value of aws.ecs.launchtype

    Michele Mancioppi committed Oct 23, 2022
    Copy the full SHA
    a5bde89 View commit details
    Browse the repository at this point in the history

  5. Add aws.logs.* support, remove spurious /aws prefix from log group

    Michele Mancioppi committed Oct 23, 2022
    Copy the full SHA
    28bc900 View commit details
    Browse the repository at this point in the history

  6. Add tests for V4 on Fargate launch type

    Michele Mancioppi committed Oct 23, 2022
    Copy the full SHA
    e518c40 View commit details
    Browse the repository at this point in the history

  7. Rebase

    Michele Mancioppi committed Oct 23, 2022
    Copy the full SHA
    400645f View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. Fix integration tests, fix behavior on Windows 

    After a surreal session of debugging, it turns out that httptest.NewServer fails on Windows by failing to bind the server socket unless the GoLang package name contains "test". To deal with that, I split the tests between "integration tests" needing a HTTP server into "ecs/test", and the other in "ecs".

In order to work around the need of being resilient to the lack of /proc/self/cgroup (which happens in our tests but, above all, when running containers on Windows), the ECVS detector is now more lenient to not finding the container id.
    Michele Mancioppi committed Oct 24, 2022
    Copy the full SHA
    c84218e View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2022

  1. Merge branch 'main' into aws_ecs_resource_attributes

    Michele Mancioppi committed Oct 28, 2022
    Copy the full SHA
    45bc0f8 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2022

  1. Merge branch 'main' into aws_ecs_resource_attributes

    Michele Mancioppi committed Nov 18, 2022
    Copy the full SHA
    db4e0a8 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2022

  1. Merge branch 'main' into aws_ecs_resource_attributes

    Michele Mancioppi committed Nov 22, 2022
    Copy the full SHA
    f3c4f53 View commit details
    Browse the repository at this point in the history