Setup PublicEndpointFn option #2342
Merged
+110
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marking all endpoints as public is a pretty good way to avoid orphan spans.
However, this is an all-or-nothing situation, which is rarely accurate. For example, a public API could have both external and internal customers.
External customers' requests need to be considered as public, while internal ones need not to.
This introduces a
WithPublicEndpointFn
option, which allows setting a specific request as public or not based on the return value of a function.A specific TraceContext baggage could then be set on all internal requests, to keep the context while discarding it for any request which doesn't have it.