fix: do not swallow error in otel echo middleware and return it to other middlewares as expected. #2209 #2210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcelaloner
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
paivagustavo,
MadVikingGod,
pellared and
hanyuancheung
as code owners
|
|
…her middlewares as expected. Middleware was swallowing the error and it was not passing it to previous middlewares as expected. Also, when we return the error from the middleware, http error handler is called automatically. Co-authored-by: Erkan Zileli <erkan.zileli@trendyol.com> Signed-off-by: Celal Öner <celal.oner@trendyol.com>
hcelaloner
force-pushed
the
fix/2209-pass-error-to-other-middlewares-correctly
branch
from
db9e99c
to
caceaab
Compare
MadVikingGod
approved these changes
Apr 27, 2022
Codecov Report
@@ Coverage Diff @@
## main #2210 +/- ##
=======================================
+ Coverage 69.4% 74.6% +5.2%
=======================================
Files 135 7 -128
Lines 6113 316 -5797
=======================================
- Hits 4244 236 -4008
+ Misses 1741 67 -1674
+ Partials 128 13 -115 |
|
Closing pull request since the issue is now resolved by #3656 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: do not swallow error in otel echo middleware and return it to other middlewares as expected.
Middleware was swallowing the error and it was not passing it to previous middlewares as expected.
Also, when we return the error from the middleware, HTTP error handler is called automatically.
Co-authored-by: Erkan Zilelierkan.zileli@trendyol.com
Signed-off-by: Celal Öner celal.oner@trendyol.com
Fixes #2209