Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[otelhttp] Remove propagation header injection #2180

Merged
merged 4 commits into from Apr 12, 2022
Merged

[otelhttp] Remove propagation header injection #2180

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a86b2a3
remove propagation header injection
TylerHelmuth Apr 11, 2022
cee2b26
Updated changelog
TylerHelmuth Apr 11, 2022
aca7d39
Merge remote-tracking branch 'origin/main' into issue-2163
TylerHelmuth Apr 11, 2022
8bff6f7
Update CHANGELOG.md
TylerHelmuth Apr 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 0 additions & 3 deletions instrumentation/net/http/otelhttp/test/handler_test.go
View file
Open in desktop
Expand Up @@ -91,9 +91,6 @@ func TestHandlerBasics(t *testing.T) {
if got, expected := rr.Result().StatusCode, http.StatusOK; got != expected {
t.Fatalf("got %d, expected %d", got, expected)
}
if got := rr.Header().Get("Traceparent"); got == "" {
t.Fatal("expected non empty trace header")
}

spans := spanRecorder.Ended()
if got, expected := len(spans), 1; got != expected {
Expand Down
1 change: 0 additions & 1 deletion instrumentation/net/http/otelhttp/wrap.go
View file
Open in desktop
Expand Up @@ -91,6 +91,5 @@ func (w *respWriterWrapper) WriteHeader(statusCode int) {
}
w.wroteHeader = true
w.statusCode = statusCode
w.props.Inject(w.ctx, propagation.HeaderCarrier(w.Header()))
w.ResponseWriter.WriteHeader(statusCode)
}