Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade otel dependencies to v1.6.0/v0.28.0 #1978

Merged

Conversation

MadVikingGod
Copy link
Contributor

This will update all packages not effected by #1977

@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #1978 (512baca) into main (200a922) will increase coverage by 2.8%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #1978     +/-   ##
=======================================
+ Coverage   68.5%   71.3%   +2.8%     
=======================================
  Files        124     127      +3     
  Lines       5366    5385     +19     
=======================================
+ Hits        3680    3844    +164     
+ Misses      1582    1434    -148     
- Partials     104     107      +3     
Impacted Files Coverage Δ
...z/gomemcache/memcache/otelmemcache/test/version.go 0.0% <0.0%> (ø)
...cache/memcache/otelmemcache/internal/attributes.go 66.6% <0.0%> (ø)
...b.org/mongo-driver/mongo/otelmongo/test/version.go 0.0% <0.0%> (ø)
...itz/gomemcache/memcache/otelmemcache/gomemcache.go 47.8% <0.0%> (+36.9%) ⬆️
....mongodb.org/mongo-driver/mongo/otelmongo/mongo.go 86.8% <0.0%> (+86.8%) ⬆️
...mongodb.org/mongo-driver/mongo/otelmongo/config.go 100.0% <0.0%> (+100.0%) ⬆️
...ongodb.org/mongo-driver/mongo/otelmongo/version.go 100.0% <0.0%> (+100.0%) ⬆️
...radfitz/gomemcache/memcache/otelmemcache/config.go 100.0% <0.0%> (+100.0%) ⬆️

@MrAlias
Copy link
Contributor

MrAlias commented Mar 24, 2022

Hmm, looks like there were some upgrades missed by multimod:

I'm going to do a manual audit and push a fix.

@MrAlias
Copy link
Contributor

MrAlias commented Mar 24, 2022

Ah! Looks like all the missing upgrades are for what @MadVikingGod pointed out are the removed parts the metric upgrade.

grep -Rn 'go\.opentelemetry\.io/otel.*v' | grep -v 'v1\.6\.0' | grep 'go.mod' | grep -v 'go.sum' | grep -v 'v0.2[78].0' | cut -d: -f1
instrumentation/host/go.mod
instrumentation/net/http/otelhttp/test/go.mod
instrumentation/net/http/otelhttp/test/go.mod
instrumentation/net/http/otelhttp/test/go.mod
instrumentation/net/http/otelhttp/go.mod
instrumentation/net/http/otelhttp/go.mod
instrumentation/net/http/otelhttp/example/go.mod
instrumentation/net/http/otelhttp/example/go.mod
instrumentation/net/http/otelhttp/example/go.mod
instrumentation/net/http/otelhttp/example/go.mod
instrumentation/github.com/gocql/gocql/otelgocql/test/go.mod
instrumentation/github.com/gocql/gocql/otelgocql/test/go.mod
instrumentation/github.com/gocql/gocql/otelgocql/test/go.mod
instrumentation/github.com/gocql/gocql/otelgocql/go.mod
instrumentation/github.com/gocql/gocql/otelgocql/go.mod
instrumentation/github.com/gocql/gocql/otelgocql/example/go.mod
instrumentation/github.com/gocql/gocql/otelgocql/example/go.mod
instrumentation/github.com/gocql/gocql/otelgocql/example/go.mod
instrumentation/github.com/astaxie/beego/otelbeego/test/go.mod
instrumentation/github.com/astaxie/beego/otelbeego/go.mod
instrumentation/github.com/astaxie/beego/otelbeego/go.mod
instrumentation/github.com/astaxie/beego/otelbeego/example/go.mod
instrumentation/github.com/astaxie/beego/otelbeego/example/go.mod
instrumentation/github.com/astaxie/beego/otelbeego/example/go.mod
instrumentation/github.com/astaxie/beego/otelbeego/example/go.mod

@MrAlias
Copy link
Contributor

MrAlias commented Mar 24, 2022

Ran go mod tidy. It added missing dependency hashes. It also upgraded one dependency in otelbeego (go.opentelemetry.io/otel) as that was upgraded in one of its dependencies.

@srenatus
Copy link

Thank you 🎈

@MrAlias MrAlias closed this Mar 25, 2022
@MrAlias MrAlias reopened this Mar 25, 2022
@MrAlias MrAlias merged commit 351b83e into open-telemetry:main Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants