Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use server span when determining status from code #1973

Merged
merged 7 commits into from Apr 7, 2022
Merged

Use server span when determining status from code #1973

merged 7 commits into from Apr 7, 2022

Commits on Mar 21, 2022

  1. Use server span when determining status from code 

    Switches to `SpanStatusFromHTTPStatusCodeAndSpanKind` with a span kind
of `SpanKindServer` so that 4xx status codes don't get labelled as
errors. Since these codes represent client errors, they make it
difficult to differentiate bad server behavior from bad client behavior.
    @kitschysynq
    kitschysynq committed Mar 21, 2022
    Copy the full SHA
    467eb5c View commit details
    Browse the repository at this point in the history

  2. Add CHANGELOG entry

    @kitschysynq
    kitschysynq committed Mar 21, 2022
    Copy the full SHA
    826e886 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2022

  1. Add test to verify that 4xx does not set error on span 

    Adds a test to verify that the span created by a request that returns
status "not found" is not an error span.
    @kitschysynq
    kitschysynq committed Mar 25, 2022
    Copy the full SHA
    e4112bc View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into kitschysynq/use-ser… 

    …ver-span-for-status
    @kitschysynq
    kitschysynq committed Mar 25, 2022
    Copy the full SHA
    1ef6570 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2022

  1. Merge remote-tracking branch 'upstream/main' into kitschysynq/use-ser… 

    …ver-span-for-status
    @kitschysynq
    kitschysynq committed Apr 3, 2022
    Copy the full SHA
    74c1c05 View commit details
    Browse the repository at this point in the history

  2. Test that span code is explicitly unset

    @kitschysynq
    kitschysynq committed Apr 3, 2022
    Copy the full SHA
    afd58b0 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2022

  1. Merge branch 'main' into kitschysynq/use-server-span-for-status

    @MrAlias
    MrAlias committed Apr 7, 2022
    Copy the full SHA
    353f3c5 View commit details
    Browse the repository at this point in the history