Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.5.0 #1921

Merged
merged 11 commits into from Mar 18, 2022
Merged

Release v1.5.0 #1921

merged 11 commits into from Mar 18, 2022

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Mar 16, 2022

Blocked on #1920


Added

Fixed

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #1921 (83b917a) into main (e4bcc4c) will increase coverage by 6.5%.
The diff coverage is 36.1%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #1921     +/-   ##
=======================================
+ Coverage   72.2%   78.8%   +6.5%     
=======================================
  Files        123     129      +6     
  Lines       5325    5395     +70     
=======================================
+ Hits        3848    4253    +405     
+ Misses      1365    1014    -351     
- Partials     112     128     +16     
Impacted Files Coverage Δ
detectors/aws/ec2/version.go 0.0% <0.0%> (ø)
detectors/aws/ecs/version.go 0.0% <0.0%> (ø)
detectors/aws/eks/version.go 0.0% <0.0%> (ø)
detectors/gcp/version.go 0.0% <0.0%> (ø)
...thub.com/Shopify/sarama/otelsarama/test/version.go 0.0% <0.0%> (ø)
...github.com/astaxie/beego/otelbeego/test/version.go 0.0% <0.0%> (ø)
...tion/github.com/astaxie/beego/otelbeego/version.go 0.0% <0.0%> (ø)
...thub.com/aws/aws-sdk-go-v2/otelaws/test/version.go 0.0% <0.0%> (ø)
...z/gomemcache/memcache/otelmemcache/test/version.go 0.0% <0.0%> (ø)
...om/emicklei/go-restful/otelrestful/test/version.go 0.0% <0.0%> (ø)
... and 48 more

@MrAlias
Copy link
Contributor Author

MrAlias commented Mar 16, 2022

I'm not planning to fix the example test because #1920 will remove it.

Copy link
Contributor

@MadVikingGod MadVikingGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Non-blocking, but probably issue worthy: I noticed that the samplers didn't have a version.go. I don't know if we want to keep up with including one for every package, as it just makes these reviews harder, or if we want to change it (for the non-stable packages).

plantfansam referenced this pull request in plantfansam/opentelemetry-go-contrib Mar 18, 2022
* Added Reason to Contributing and Updated TracerConfig

* PR comment fixup

* Changed how span Options work.

* Fix Markdown linting

* Added meter configs.

* Fixes from PR comments

* fix for missing instrument

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@MrAlias
Copy link
Contributor Author

MrAlias commented Mar 18, 2022

LGTM

Non-blocking, but probably issue worthy: I noticed that the samplers didn't have a version.go. I don't know if we want to keep up with including one for every package, as it just makes these reviews harder, or if we want to change it (for the non-stable packages).

I'll add one here for consistency.

Copy link
Member

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MrAlias MrAlias merged commit add6caa into open-telemetry:main Mar 18, 2022
@MrAlias MrAlias deleted the release-v1.5.0 branch March 18, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants