New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
otelgrpc: add WithMeterProvider option #1094
otelgrpc: add WithMeterProvider option #1094
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1094 +/- ##
=======================================
- Coverage 69.4% 69.3% -0.1%
=======================================
Files 135 135
Lines 6113 6118 +5
=======================================
+ Hits 4243 4244 +1
- Misses 1742 1746 +4
Partials 128 128
|
72d8e94
to
9aaa7c7
Compare
@codeboten please rebase @Aneurysm9 @MrAlias please help us with this PR. |
9aaa7c7
to
6ea3acb
Compare
@codeboten please rebase |
6ea3acb
to
784fdc3
Compare
@bogdandrutu done. @open-telemetry/go-approvers would be great to get some feedback on this PR before I need to rebase again, thanks! |
dbd5c5d
to
775d585
Compare
@codeboten you need another rebase |
@bogdandrutu I'm not seeing anything needing rebase in github 🤔 i did rebase yesterday though. |
@codeboten do you have a plan or design doc/issue for the future metric instruments planned to be added here? Is this a PR you plan to submit after this? I want to be sure we don't couple this instrumentation to the unstable metrics signal without a plan forward with how it will be used. |
The metrics I would expect we would want out of this instrumentation would likely be what's defined in the spec here. This PR is specifically to allow the grpc instrumentation to configure a meter provider in the collector (see open-telemetry/opentelemetry-collector#4030) as we have the ability for today with the tracer provider. I don't immediately plan on adding metrics to the instrumentation as you mentioned the stability isn't there yet, but i can add an issue and follow up on it at a later time if that works for you. |
@MrAlias is there a way to move this PR forward or would you prefer to close it and reinstate when the metrics api is stable? I'm not sure how to move forward at this point. |
0cd881b
to
7632a0f
Compare
@MrAlias @codeboten the metrics API is stable, let's move forward with this PR :) |
It looks like #2700 supersedes this, closing. Please reopen if this was in error. |
Adding the ability to set a MeterProvider to
otelgrpc
instrumentation for future use.