Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otelaws] Add DynamoDB and SQS X-Ray specific attributes #2879

Merged
merged 7 commits into from Nov 3, 2022

Conversation

lukestoward
Copy link
Contributor

@lukestoward lukestoward commented Oct 22, 2022

The AWS SDK v2 instrumentation library otelaws does not set SQS specific operational attributes. The goal here is to capture the SQS queue URL making it available to the AWS X-Ray exporter (in the collector) in order to provide more detailed telemetry data to X-Ray. Based on the PR comments, I've updated this PR to only include messaging attributes from the semantic conventions and not the AWS X-Ray bespoke attributes. This change will ensure the attributes are captured for SQS operations and made available to the exporters. Separately, we will need to update the collector exporter to extract the specific semantic convention attributes during the mapping between OTel and X-Ray.

Below is an example trace from the AWS X-Ray console that demonstrates what is possible once DynamoDB table and SQS Queue URL information is captured and exported to X-Ray.

Before:
image

After:
image

@codecov
Copy link

codecov bot commented Oct 22, 2022

Codecov Report

Merging #2879 (164fd7b) into main (0893cda) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2879     +/-   ##
=======================================
+ Coverage   69.4%   69.6%   +0.1%     
=======================================
  Files        146     147      +1     
  Lines       6752    6785     +33     
=======================================
+ Hits        4692    4725     +33     
  Misses      1944    1944             
  Partials     116     116             
Impacted Files Coverage Δ
...github.com/aws/aws-sdk-go-v2/otelaws/attributes.go 80.0% <ø> (ø)
...hub.com/aws/aws-sdk-go-v2/otelaws/sqsattributes.go 100.0% <100.0%> (ø)

@lukestoward
Copy link
Contributor Author

lukestoward commented Oct 24, 2022

Hey @Aneurysm9 / @dmathieu, would you mind taking a look at this PR when you have a few minutes please. Thanks 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants