[exporter/awsxray] Favour semconv attributes for QueueURL and TableName #16076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukestoward
commented
Nov 4, 2022
|
Pinging @willarmiros as code owner |
|
@willarmiros please could you take a look at this PR 😄 thanks. |
willarmiros
reviewed
Nov 10, 2022
There was a problem hiding this comment.
I think in general this LGTM, just am having a hard time reading our own code and want a sanity check :)
Thank you very much for the contributions though! If you were so inclined, it would be very helpful to update our translation documentation as well!
TylerHelmuth
approved these changes
Nov 10, 2022
Aneurysm9
approved these changes
Nov 10, 2022
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector-contrib
that referenced
this pull request
Nov 16, 2022
…me (open-telemetry#16076) * [exporter/awsxray] Favour semconv attributes when populating Queue URL and Table Name * Fix linter complaint about spelling * Reinstate redundant test code
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
…me (open-telemetry#16076) * [exporter/awsxray] Favour semconv attributes when populating Queue URL and Table Name * Fix linter complaint about spelling * Reinstate redundant test code
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
THe AWS X-Ray Exporter does not use semantic convention attributes when attempting to populate the
queueURLandtableNameattributes. Instead it only looks for the X-Ray custom attributes. This PR extends the behaviour to favour the semantic convention attributes (if set). This was motivated by the recent discussion on the PR that extended the AWS-SDK-Go-v2 instrumentation libraryotelaws. See discussion. (cc. @Aneurysm9)Link to tracking Issue: #16075