Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelaws: adding dynamodb attributes #1582

Merged
merged 16 commits into from Feb 25, 2022

Conversation

jennynilsen
Copy link
Contributor

When appending the middlewares to a dynamodb client, no dynamodb attributes are added to the spans.

This PR :

adds dynamodb attributes that correspond to the dynamodb operation to the spans
allows someone to provide their own function to set custom attributes
adds a way to determine the attributes to set based on service automatically

Copy link
Member

@Aneurysm9 Aneurysm9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I think I like the approach overall. My comments are mostly stylistic/structural.

jennynilsen and others added 4 commits January 28, 2022 15:52
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
CHANGELOG.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #1582 (2197014) into main (f7fe163) will increase coverage by 0.7%.
The diff coverage is 98.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #1582     +/-   ##
=======================================
+ Coverage   69.6%   70.3%   +0.7%     
=======================================
  Files        127     128      +1     
  Lines       5391    5537    +146     
=======================================
+ Hits        3755    3898    +143     
- Misses      1498    1500      +2     
- Partials     138     139      +1     
Impacted Files Coverage Δ
...github.com/aws/aws-sdk-go-v2/otelaws/attributes.go 81.2% <62.5%> (-18.8%) ⬇️
...tation/github.com/aws/aws-sdk-go-v2/otelaws/aws.go 94.1% <100.0%> (+1.1%) ⬆️
...ion/github.com/aws/aws-sdk-go-v2/otelaws/config.go 100.0% <100.0%> (ø)
...om/aws/aws-sdk-go-v2/otelaws/dynamodbattributes.go 100.0% <100.0%> (ø)

@Aneurysm9 Aneurysm9 merged commit 4be24de into open-telemetry:main Feb 25, 2022
@MrAlias MrAlias mentioned this pull request Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants