OTel-Go Consistent Probability Sampler and conformance tests #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
requested review from
Aneurysm9,
dashpole,
evantorrie,
MadVikingGod,
MrAlias,
paivagustavo,
pellared and
XSAM
as code owners
jmacd
changed the title
|
With a minor exception detailed in open-telemetry/opentelemetry-specification#2319, this PR fully implements the already-merged specification for probability samplers. |
|
👀 |
MrAlias
approved these changes
Mar 23, 2022
…trib into jmacd/probsample
…contrib into jmacd/probsample
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
…contrib into jmacd/probsample
|
DE-linted. |
Aneurysm9
reviewed
Apr 1, 2022
instrumentation/github.com/astaxie/beego/otelbeego/example_middleware_test.go
Outdated
Show resolved
Hide resolved
Aneurysm9
approved these changes
Apr 25, 2022
This was referenced Apr 26, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation matches the specification in https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/tracestate-probability-sampling.md
consistent.ParentProbabilitySamplerconsistent.ProbabilitySamplerThis follows the two OTEPs on this topic:
https://github.com/open-telemetry/oteps/blob/main/text/trace/0168-sampling-propagation.md
https://github.com/open-telemetry/oteps/blob/main/text/trace/0170-sampling-probability.md