Fixed issue #2260 where attributes for DynamoDB were not added becaus…

…e of a wrong name in the servicemap.
open-telemetry · May 13, 2022 · 736e539 · 736e539
1 parent 6feda83
commit 736e539
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/attributes.go b/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/attributes.go
@@ -16,6 +16,7 @@ package otelaws // import "go.opentelemetry.io/contrib/instrumentation/github.co
 
 import (
 	"context"
+	"github.com/aws/aws-sdk-go-v2/service/dynamodb"
 
 	v2Middleware "github.com/aws/aws-sdk-go-v2/aws/middleware"
 	"github.com/aws/smithy-go/middleware"
@@ -32,7 +33,7 @@ const (
 )
 
 var servicemap = map[string]AttributeSetter{
-	"dynamodb": DynamoDBAttributeSetter,
+	dynamodb.ServiceID: DynamoDBAttributeSetter,
 }
 
 func OperationAttr(operation string) attribute.KeyValue {

diff --git a/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/dynamodbattributes.go b/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/dynamodbattributes.go
@@ -25,7 +25,7 @@ import (
 	semconv "go.opentelemetry.io/otel/semconv/v1.10.0"
 )
 
-// DynamoDBAttributeSetter sets DynamoDB specific attributes depending on the the DynamoDB operation being performed.
+// DynamoDBAttributeSetter sets DynamoDB specific attributes depending on the DynamoDB operation being performed.
 func DynamoDBAttributeSetter(ctx context.Context, in middleware.InitializeInput) []attribute.KeyValue {
 
 	dynamodbAttributes := []attribute.KeyValue{semconv.DBSystemKey.String("dynamodb")}