Apply suggestions from code review

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
open-telemetry · Aug 17, 2022 · 5804768 · 5804768
1 parent 2e65071
commit 5804768
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/detectors/aws/ecs/ecs.go b/detectors/aws/ecs/ecs.go
@@ -168,10 +168,8 @@ func (detector *resourceDetector) getLogsAttributes(metadata *ecsmetadata.Contai
 	awsAccount := r.FindStringSubmatch(containerArn)[1]
 
 	return []attribute.KeyValue{
-		semconv.AWSLogGroupNamesKey.String(logsOptions.AwsLogsGroup),
-		semconv.AWSLogGroupARNsKey.String(fmt.Sprintf("arn:aws:logs:%s:%s:log-group:%s:*", logsRegion, awsAccount, logsOptions.AwsLogsGroup)),
-		semconv.AWSLogStreamNamesKey.String(logsOptions.AwsLogsStream),
-		semconv.AWSLogStreamARNsKey.String(fmt.Sprintf("arn:aws:logs:%s:%s:log-group:%s:log-stream:%s", logsRegion, awsAccount, logsOptions.AwsLogsGroup, logsOptions.AwsLogsStream)),
+		semconv.AWSLogGroupARNsKey.StringSlice([]string{fmt.Sprintf("arn:aws:logs:%s:%s:log-group:%s:*", logsRegion, awsAccount, logsOptions.AwsLogsGroup)}),
+		semconv.AWSLogStreamARNsKey.StringSlice([]string{fmt.Sprintf("arn:aws:logs:%s:%s:log-group:%s:log-stream:%s", logsRegion, awsAccount, logsOptions.AwsLogsGroup, logsOptions.AwsLogsStream)}),
 	}, nil
 }