Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify GH Actions to remove include-prerelease #3827

Merged

Conversation

cijothomas
Copy link
Member

We have this warning now:
Warning: Unexpected input(s) 'include-prerelease', valid inputs are ['dotnet-version', 'dotnet-quality', 'global-json-file', 'source-url', 'owner', 'config-file']

due to
actions/setup-dotnet#315

This PR removes the "include-prerelease", as it no longer required.

@cijothomas cijothomas requested a review from a team as a code owner October 26, 2022 18:51
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #3827 (ff53486) into main (88c1864) will increase coverage by 0.22%.
The diff coverage is n/a.

❗ Current head ff53486 differs from pull request most recent head 0e0a702. Consider uploading reports for the commit 0e0a702 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3827      +/-   ##
==========================================
+ Coverage   87.22%   87.44%   +0.22%     
==========================================
  Files         280      280              
  Lines       10767    10767              
==========================================
+ Hits         9391     9415      +24     
+ Misses       1376     1352      -24     
Impacted Files Coverage Δ
...Propagators/OpenTelemetryPropagatorsEventSource.cs 87.50% <0.00%> (-12.50%) ⬇️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 73.52% <0.00%> (-8.83%) ⬇️
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 97.14% <0.00%> (-2.86%) ⬇️
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 97.65% <0.00%> (+0.78%) ⬆️
...metryProtocol/Implementation/ActivityExtensions.cs 96.21% <0.00%> (+4.32%) ⬆️
...tation/OpenTelemetryProtocolExporterEventSource.cs 95.00% <0.00%> (+10.00%) ⬆️
...porter.OpenTelemetryProtocol/OtlpMetricExporter.cs 86.36% <0.00%> (+13.63%) ⬆️
...xporter.OpenTelemetryProtocol/OtlpTraceExporter.cs 80.76% <0.00%> (+34.61%) ⬆️
...entation/ExportClient/OtlpGrpcTraceExportClient.cs 78.57% <0.00%> (+42.85%) ⬆️

@vishweshbankwar
Copy link
Member

Also




@cijothomas cijothomas merged commit 20cdc51 into open-telemetry:main Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants