Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dust off Prometheus Exporters #3507

Merged
merged 7 commits into from
Aug 1, 2022

Conversation

reyang
Copy link
Member

@reyang reyang commented Jul 30, 2022

No description provided.

@reyang reyang marked this pull request as ready for review July 30, 2022 05:52
@reyang reyang requested a review from a team as a code owner July 30, 2022 05:52
@codecov
Copy link

codecov bot commented Jul 30, 2022

Codecov Report

Merging #3507 (c9c1f90) into main (084244c) will decrease coverage by 0.01%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3507      +/-   ##
==========================================
- Coverage   86.67%   86.65%   -0.02%     
==========================================
  Files         275      275              
  Lines        9970     9963       -7     
==========================================
- Hits         8641     8633       -8     
- Misses       1329     1330       +1     
Impacted Files Coverage Δ
.../PrometheusExporterApplicationBuilderExtensions.cs 100.00% <ø> (ø)
...rometheusExporterEndpointRouteBuilderExtensions.cs 100.00% <ø> (ø)
...metheus.AspNetCore/PrometheusExporterMiddleware.cs 67.85% <ø> (ø)
...Prometheus.AspNetCore/PrometheusExporterOptions.cs 50.00% <ø> (ø)
...Listener/Internal/PrometheusExporterEventSource.cs 27.77% <ø> (ø)
...heus.HttpListener/Internal/PrometheusSerializer.cs 78.21% <ø> (ø)
...s.HttpListener/Internal/PrometheusSerializerExt.cs 100.00% <ø> (ø)
...theusHttpListenerMeterProviderBuilderExtensions.cs 58.33% <66.66%> (ø)
...rometheusExporterMeterProviderBuilderExtensions.cs 100.00% <100.00%> (ø)
...tpListener/Internal/PrometheusCollectionManager.cs 78.04% <100.00%> (ø)
... and 8 more

@Kielek
Copy link
Contributor

Kielek commented Aug 1, 2022

Not directly related to the PR, do you have a plan to release prometheus exporters based on 1.3.0? Or only on 1.4.0?
In AutoIntrumentation we have reference to old package, if we will have it based 1.3.0 we can schedule upgrade earlier.

@cijothomas cijothomas merged commit 8d5d3d6 into open-telemetry:main Aug 1, 2022
@reyang reyang deleted the reyang/prometheus-dust-off branch August 1, 2022 17:33
@cijothomas
Copy link
Member

Not directly related to the PR, do you have a plan to release prometheus exporters based on 1.3.0? Or only on 1.4.0? In AutoIntrumentation we have reference to old package, if we will have it based 1.3.0 we can schedule upgrade earlier.

We are doing a release shortly! (was supposed to be last week, but delayed.!). I think it'll be starting off 1.4.x series. Do you need 1.3.0 based one prometheus? (lets slack chat on this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants