Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(jaeger): enable service performance monitoring #1534

Closed

Conversation

tranngoclam
Copy link
Contributor

Changes

image

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@tranngoclam tranngoclam requested a review from a team as a code owner April 17, 2024 04:11
@github-actions github-actions bot added the helm-update-required Requires an update to the Helm chart when released label Apr 17, 2024
@puckpuck
Copy link
Contributor

This will require changes to how we bring in the Jaeger subchart for our Helm deployment. @tranngoclam have you looked into what needs to change on that side?

@puckpuck
Copy link
Contributor

I looked into doing this in Helm, and with the current Jaeger Helm chart, we don't have a way to add volume mounts to the Jaeger pod. The helm chart does have a pattern for other aspects of it, but not for the all-in-one mode that we use. Doing this for the demo in Helm may require an update to the Jaeger's Helm chart.

Copy link

github-actions bot commented May 7, 2024

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 7, 2024
Copy link

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helm-update-required Requires an update to the Helm chart when released Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants