Instrument obsreport.Processor #6607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 91.07% // Head: 91.21% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6607 +/- ##
==========================================
+ Coverage 91.07% 91.21% +0.14%
==========================================
Files 242 244 +2
Lines 14054 14165 +111
==========================================
+ Hits 12800 12921 +121
+ Misses 1004 995 -9
+ Partials 250 249 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jpkrohling
approved these changes
Nov 23, 2022
.chloggen/obsreport-processor.yaml
Outdated
| # One or more tracking issues or pull requests related to the change | ||
| issues: [6607] | ||
|
|
||
| # (Optional) One or more lines of additional information to render under the primary note. |
There was a problem hiding this comment.
Can you remove this if it's unused?
There was a problem hiding this comment.
Thanks for the review! Removed.
jpkrohling
reviewed
Nov 23, 2022
obsreport/obsreport_processor.go
Outdated
| return newProcessor(cfg, featuregate.GetRegistry()) | ||
| } | ||
|
|
||
| // Deprecated: [v0.65.0] use NewProcessor. |
There was a problem hiding this comment.
This PR will probably land after we release 0.66.0 (happening now), so, this needs to be updated.
There was a problem hiding this comment.
Thanks for pointing this out! Removed this deprecated function now.
|
@paivagustavo, can you review this one as the author of the PR that this one is using as reference? |
paivagustavo
approved these changes
Nov 28, 2022
There was a problem hiding this comment.
LGTM! Thanks @moh-osman3, I've added one small note regarding consistency with other otel instrumentations.
Sorry for taking too long, I was away in vacation :)
bogdandrutu
pushed a commit
to bogdandrutu/opentelemetry-collector
that referenced
this pull request
Nov 28, 2022
* Instrument obsreport.Processor * add processor promchecker tests * add chloggen * run make genpdata and fix linter errors * address review feedback and retest * pass cfg into createOtelMetrics
bogdandrutu
pushed a commit
to bogdandrutu/opentelemetry-collector
that referenced
this pull request
Dec 1, 2022
* Instrument obsreport.Processor * add processor promchecker tests * add chloggen * run make genpdata and fix linter errors * address review feedback and retest * pass cfg into createOtelMetrics
bogdandrutu
pushed a commit
to bogdandrutu/opentelemetry-collector
that referenced
this pull request
Dec 5, 2022
* Instrument obsreport.Processor * add processor promchecker tests * add chloggen * run make genpdata and fix linter errors * address review feedback and retest * pass cfg into createOtelMetrics
bogdandrutu
pushed a commit
to bogdandrutu/opentelemetry-collector
that referenced
this pull request
Dec 5, 2022
* Instrument obsreport.Processor * add processor promchecker tests * add chloggen * run make genpdata and fix linter errors * address review feedback and retest * pass cfg into createOtelMetrics
bogdandrutu
pushed a commit
to bogdandrutu/opentelemetry-collector
that referenced
this pull request
Dec 6, 2022
* Instrument obsreport.Processor * add processor promchecker tests * add chloggen * run make genpdata and fix linter errors * address review feedback and retest * pass cfg into createOtelMetrics
bogdandrutu
pushed a commit
to bogdandrutu/opentelemetry-collector
that referenced
this pull request
Dec 6, 2022
* Instrument obsreport.Processor * add processor promchecker tests * add chloggen * run make genpdata and fix linter errors * address review feedback and retest * pass cfg into createOtelMetrics
bogdandrutu
added a commit
that referenced
this pull request
Dec 6, 2022
…and] to collector package (#6608) * Instrument obsreport.Processor (#6607) * Instrument obsreport.Processor * add processor promchecker tests * add chloggen * run make genpdata and fix linter errors * address review feedback and retest * pass cfg into createOtelMetrics * Update otelcol/moved.go Co-authored-by: Alex Boten <alex@boten.ca> * Update service/collector.go Co-authored-by: Alex Boten <alex@boten.ca> Co-authored-by: Moh Osman <59479562+moh-osman3@users.noreply.github.com> Co-authored-by: Alex Boten <alex@boten.ca>
jaronoff97
added a commit
to lightstep/opentelemetry-collector
that referenced
this pull request
Dec 14, 2022
* Instrument obsreport.Processor * add processor promchecker tests * add chloggen * run make genpdata and fix linter errors * address review feedback and retest * pass cfg into createOtelMetrics
jaronoff97
pushed a commit
to lightstep/opentelemetry-collector
that referenced
this pull request
Dec 14, 2022
…and] to collector package (open-telemetry#6608) * Instrument obsreport.Processor (open-telemetry#6607) * Instrument obsreport.Processor * add processor promchecker tests * add chloggen * run make genpdata and fix linter errors * address review feedback and retest * pass cfg into createOtelMetrics * Update otelcol/moved.go Co-authored-by: Alex Boten <alex@boten.ca> * Update service/collector.go Co-authored-by: Alex Boten <alex@boten.ca> Co-authored-by: Moh Osman <59479562+moh-osman3@users.noreply.github.com> Co-authored-by: Alex Boten <alex@boten.ca>
jaronoff97
added a commit
to lightstep/opentelemetry-collector
that referenced
this pull request
Dec 14, 2022
* Instrument obsreport.Processor * add processor promchecker tests * add chloggen * run make genpdata and fix linter errors * address review feedback and retest * pass cfg into createOtelMetrics
jaronoff97
pushed a commit
to lightstep/opentelemetry-collector
that referenced
this pull request
Dec 14, 2022
…and] to collector package (open-telemetry#6608) * Instrument obsreport.Processor (open-telemetry#6607) * Instrument obsreport.Processor * add processor promchecker tests * add chloggen * run make genpdata and fix linter errors * address review feedback and retest * pass cfg into createOtelMetrics * Update otelcol/moved.go Co-authored-by: Alex Boten <alex@boten.ca> * Update service/collector.go Co-authored-by: Alex Boten <alex@boten.ca> Co-authored-by: Moh Osman <59479562+moh-osman3@users.noreply.github.com> Co-authored-by: Alex Boten <alex@boten.ca>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR instruments obsreport.Processor with otel go. This is a followup PR that is based on similar changes made for obsreport.Receiver: #6222
Link to tracking Issue: Part of #816
Testing:
Ran contrib collector with memory_limiter processor and prometheusreceiver + sent traces from demo client and confirmed that new metrics show up. Tested both with feature gate disabled and enabled.
From output of $ curl localhost:8888/metrics