Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start moving telemetry initialization to service/telemetry #6275

Merged
merged 1 commit into from Oct 13, 2022

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Oct 11, 2022

Updates #5564

@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Base: 92.03% // Head: 91.97% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (0262fbd) compared to base (a9f41a2).
Patch coverage: 80.51% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6275      +/-   ##
==========================================
- Coverage   92.03%   91.97%   -0.06%     
==========================================
  Files         218      219       +1     
  Lines       13203    13239      +36     
==========================================
+ Hits        12151    12177      +26     
- Misses        832      840       +8     
- Partials      220      222       +2     
Impacted Files Coverage Δ
...ervice/internal/proctelemetry/process_telemetry.go 71.79% <ø> (ø)
service/service.go 69.44% <64.28%> (-1.99%) ⬇️
service/telemetry/telemetry.go 83.33% <83.33%> (ø)
service/collector.go 78.90% <100.00%> (ø)
service/internal/grpclog/logger.go 80.00% <100.00%> (ø)
service/telemetry/otel_trace_sampler.go 66.66% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

service/telemetry/telemetry.go Outdated Show resolved Hide resolved
service/telemetry/telemetry.go Outdated Show resolved Hide resolved
Signed-off-by: Bogdan <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu merged commit dfb21cf into open-telemetry:main Oct 13, 2022
@bogdandrutu bogdandrutu deleted the mvtelemetry branch October 13, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants