Unmarshalv2 #10132
Draft
Unmarshalv2 #10132
+175
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10132 +/- ##
==========================================
- Coverage 91.87% 91.60% -0.27%
==========================================
Files 360 354 -6
Lines 16725 16773 +48
==========================================
- Hits 15366 15365 -1
- Misses 1021 1065 +44
- Partials 338 343 +5 ☔ View full report in Codecov by Sentry. |
bogdandrutu
reviewed
May 20, 2024
| // UnmarshalerV2 interface may be implemented by types to customize their behavior when being unmarshaled from a Conf. | ||
| type UnmarshalerV2 interface { | ||
| // UnmarshalV2 unmarshals the struct in a custom way. | ||
| UnmarshalV2(unmarshal func(interface{}) error) error |
There was a problem hiding this comment.
Can you please document how the "unmarshal" func can be used?
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP to discuss a new Unmarshaler interface.