Deprecate last funcs/structs in componenthelper (#5069)

Fixes #4681

These funcs/structs are not used, and in case we need them in multiple places we can add them to `component` directly.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

CHANGELOG.md

@@ -37,6 +37,7 @@
   - Deprecate `pdata.AttributeValueTypeArray` type in favor of `pdata.ValueTypeSlice`
   - Deprecate `pdata.NewAttributeValueArray` func in favor of `pdata.NewValueSlice`
 - Deprecate global flag in `featuregates` (#5060)
+- Deprecate last funcs/structs in componenthelper (#5069)
 - Change structs in otlpgrpc to follow standard go encoding interfaces (#5062)
   - Deprecate UnmarshalJSON[Traces|Metrics|Logs][Reques|Response] in favor of `UnmarshalJSON`.
   - Deprecate [Traces|Metrics|Logs][Reques|Response].Marshal in favor of `MarshalProto`.

component/componenthelper/component.go

@@ -18,19 +18,17 @@ import (
 	"go.opentelemetry.io/collector/component"
 )
 
-// Option represents the possible options for New.
+// Deprecated: [v0.48.0] will be removed.
 type Option func(*baseComponent)
 
-// WithStart overrides the default `Start` function for a component.Component.
-// The default always returns nil.
+// Deprecated: [v0.48.0] embed component.StartFunc directly.
 func WithStart(startFunc component.StartFunc) Option {
 	return func(o *baseComponent) {
 		o.StartFunc = startFunc
 	}
 }
 
-// WithShutdown overrides the default `Shutdown` function for a component.Component.
-// The default always returns nil.
+// Deprecated: [v0.48.0] embed component.ShutdownFunc directly.
 func WithShutdown(shutdownFunc component.ShutdownFunc) Option {
 	return func(o *baseComponent) {
 		o.ShutdownFunc = shutdownFunc
@@ -42,7 +40,7 @@ type baseComponent struct {
 	component.ShutdownFunc
 }
 
-// New returns a component.Component configured with the provided options.
+// Deprecated: [v0.48.0] embed component.StartFunc and component.ShutdownFunc directly.
 func New(options ...Option) component.Component {
 	bc := &baseComponent{}
 

internal/sharedcomponent/sharedcomponent_test.go

@@ -22,20 +22,24 @@ import (
 	"github.com/stretchr/testify/assert"
 
 	"go.opentelemetry.io/collector/component"
-	"go.opentelemetry.io/collector/component/componenthelper"
 	"go.opentelemetry.io/collector/component/componenttest"
 	"go.opentelemetry.io/collector/config"
 )
 
 var id = config.NewComponentID("test")
 
+type baseComponent struct {
+	component.StartFunc
+	component.ShutdownFunc
+}
+
 func TestNewSharedComponents(t *testing.T) {
 	comps := NewSharedComponents()
 	assert.Len(t, comps.comps, 0)
 }
 
 func TestSharedComponents_GetOrAdd(t *testing.T) {
-	nop := componenthelper.New()
+	nop := &baseComponent{}
 	createNop := func() component.Component { return nop }
 
 	comps := NewSharedComponents()
@@ -54,14 +58,15 @@ func TestSharedComponent(t *testing.T) {
 	wantErr := errors.New("my error")
 	calledStart := 0
 	calledStop := 0
-	comp := componenthelper.New(
-		componenthelper.WithStart(func(ctx context.Context, host component.Host) error {
+	comp := &baseComponent{
+		StartFunc: func(ctx context.Context, host component.Host) error {
 			calledStart++
 			return wantErr
-		}), componenthelper.WithShutdown(func(ctx context.Context) error {
+		},
+		ShutdownFunc: func(ctx context.Context) error {
 			calledStop++
 			return wantErr
-		}))
+		}}
 	createComp := func() component.Component { return comp }
 
 	comps := NewSharedComponents()

internal/testcomponents/example_extension.go

@@ -18,7 +18,6 @@ import (
 	"context"
 
 	"go.opentelemetry.io/collector/component"
-	"go.opentelemetry.io/collector/component/componenthelper"
 	"go.opentelemetry.io/collector/config"
 )
 
@@ -33,8 +32,18 @@ type ExampleExtensionCfg struct {
 
 const extType = "exampleextension"
 
+type extension struct {
+	component.StartFunc
+	component.ShutdownFunc
+}
+
 // ExampleExtensionFactory is factory for ExampleExtensionCfg.
-var ExampleExtensionFactory = component.NewExtensionFactory(extType, createExtensionDefaultConfig, createExtension)
+var ExampleExtensionFactory = component.NewExtensionFactory(
+	extType,
+	createExtensionDefaultConfig,
+	func(context.Context, component.ExtensionCreateSettings, config.Extension) (component.Extension, error) {
+		return &extension{}, nil
+	})
 
 // CreateDefaultConfig creates the default configuration for the Extension.
 func createExtensionDefaultConfig() config.Extension {
@@ -45,8 +54,3 @@ func createExtensionDefaultConfig() config.Extension {
 		ExtraListSetting:  nil,
 	}
 }
-
-// CreateExtension creates an Extension based on this config.
-func createExtension(context.Context, component.ExtensionCreateSettings, config.Extension) (component.Extension, error) {
-	return componenthelper.New(), nil
-}