Remove Created state from collector to make shutdown behave more in l…

…ine with language standards

Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com>

service/collector.go

@@ -48,7 +48,6 @@ const (
 	Running
 	Closing
 	Closed
-	Created
 )
 
 // (Internal note) Collector Lifecycle:
@@ -91,7 +90,7 @@ func New(set CollectorSettings) (*Collector, error) {
 	}
 
 	state := atomic.Value{}
-	state.Store(Created)
+	state.Store(Starting)
 	return &Collector{
 		logger: zap.NewNop(), // Set a Nop logger as a place holder until a logger is created based on configuration
 

service/collector_test.go

@@ -159,7 +159,7 @@ func TestCollector_ShutdownBeforeRun(t *testing.T) {
 	collectorTelemetry = &colTelemetry{}
 	defer func() { collectorTelemetry = preservedAppTelemetry }()
 
-	factories, err := testcomponents.DefaultFactories()
+	factories, err := testcomponents.NewDefaultFactories()
 	require.NoError(t, err)
 
 	set := CollectorSettings{
@@ -170,14 +170,8 @@ func TestCollector_ShutdownBeforeRun(t *testing.T) {
 	col, err := New(set)
 	require.NoError(t, err)
 
-	// Calling shutdown before collector is running should not stop it from running
+	// Calling shutdown before collector is running should cause it to return quickly
 	col.Shutdown()
-	select {
-	case <-col.shutdownChan:
-		require.Fail(t, "shutdownChan was closed early")
-	case <-time.After(time.Second):
-		// Channel did not report closed after 1 second move on with test.
-	}
 
 	colDone := make(chan struct{})
 	go func() {
@@ -188,10 +182,6 @@ func TestCollector_ShutdownBeforeRun(t *testing.T) {
 		}
 	}()
 
-	assert.Eventually(t, func() bool {
-		return Running == col.GetState()
-	}, time.Second*2, time.Millisecond*200)
-
 	col.Shutdown()
 	<-colDone
 	assert.Eventually(t, func() bool {