short meter with metric v0.29.0 #9337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
codeboten
reviewed
Apr 18, 2022
There was a problem hiding this comment.
Thanks @Icarus9913 for the PR, please sign the CLA so we can proceed with the review
|
signed |
codeboten
approved these changes
Apr 19, 2022
codeboten
referenced
this pull request
in codeboten/opentelemetry-collector-contrib
Apr 19, 2022
This is a follow up to #9337.
codeboten
referenced
this pull request
in codeboten/opentelemetry-collector-contrib
May 3, 2022
This is a follow up to #9337.
codeboten
pushed a commit
that referenced
this pull request
Jun 3, 2022
* [simpleprometheus] update example to use Meter directly This is a follow up to #9337. * update example to avoid using global
kentquirk
pushed a commit
to McSick/opentelemetry-collector-contrib
that referenced
this pull request
Jun 14, 2022
…n-telemetry#9364) * [simpleprometheus] update example to use Meter directly This is a follow up to open-telemetry#9337. * update example to avoid using global
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with otel v0.29.0 released.
I followed the pr open-telemetry/opentelemetry-go#2750 to short the meter definition.