Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extension/sigv4authextension] Enable component #8518

Merged
merged 9 commits into from Mar 21, 2022

Conversation

erichsueh3
Copy link
Contributor

Description:
Enables the sigv4authextension component

@erichsueh3
Copy link
Contributor Author

Looks like I need to run go mod tidy to get these tests to set up correctly, but when I do that I get a gopkg.in/DataDog/dd-trace-go.v1@v1.37.0 requires github.com/go-chi/chi/v4@v4.0.0-rc1: reading github.com/go-chi/chi/go.mod at revision v4.0.0-rc1: unknown revision v4.0.0-rc1 error, and I'm not too sure what to do about this.

@mx-psi
Copy link
Member

mx-psi commented Mar 17, 2022

Looks like I need to run go mod tidy to get these tests to set up correctly, but when I do that I get a gopkg.in/DataDog/dd-trace-go.v1@v1.37.0 requires github.com/go-chi/chi/v4@v4.0.0-rc1: reading github.com/go-chi/chi/go.mod at revision v4.0.0-rc1: unknown revision v4.0.0-rc1 error, and I'm not too sure what to do about this.

The dependency can be found on the official Go proxy (you can download it here https://proxy.golang.org/github.com/go-chi/chi/v4/@v/v4.0.0-rc1.zip) but not on Github (https://github.com/go-chi/chi/releases/tag/v4.0.0-rc1 returns a 404).

You are probably not using the official Go proxy (what does go env | grep GOPROXY output?) while CI is, which would explain this. If you set GOPROXY="https://proxy.golang.org,direct" it should work (unless you can't access the official Go proxy, in which case... I can do it for you maybe?).

I will try to report this upstream and also to our APM tracer team (I work at Datadog) so that this doesn't happen.

@mx-psi
Copy link
Member

mx-psi commented Mar 17, 2022

Reported at DataDog/dd-trace-go#1188 (comment) and go-chi/chi#713

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember that to include this on the binaries you have to make a PR on the releases repo, see e.g. open-telemetry/opentelemetry-collector-releases#78 I see you already did that 😅

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't seem to create a PR to your branch @erichsueh3, but here's the gotidy change: codeboten@5b76e2d

@Aneurysm9
Copy link
Member

You are probably not using the official Go proxy (what does go env | grep GOPROXY output?) while CI is, which would explain this. If you set GOPROXY="https://proxy.golang.org,direct" it should work (unless you can't access the official Go proxy, in which case... I can do it for you maybe?).

We cannot access the official Go proxy, so I consider us canaries for bad modules! :)

@erichsueh3
Copy link
Contributor Author

You are probably not using the official Go proxy (what does go env | grep GOPROXY output?) while CI is, which would explain this. If you set GOPROXY="https://proxy.golang.org,direct" it should work (unless you can't access the official Go proxy, in which case... I can do it for you maybe?).

We cannot access the official Go proxy, so I consider us canaries for bad modules! :)

Tried the suggested change to set GOPROXY="https://proxy.golang.org,direct" and yes, it still doesn't work

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a changelog entry

@jpkrohling jpkrohling merged commit 97695a5 into open-telemetry:main Mar 21, 2022
foxlegend pushed a commit to foxlegend/opentelemetry-collector-contrib that referenced this pull request Apr 8, 2022
* enable sigv4 auth extension component

* fixed go.mod

* fixed go.sum

* aws sdk go v2

* fixed go.mod files post merge conflict

* gotidy change

* CHANGELOG entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants