Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/syslogexporter] use errors.Join instead of go.uber.org/multierr #32925

Merged
merged 4 commits into from May 8, 2024
Merged

[exporter/syslogexporter] use errors.Join instead of go.uber.org/multierr #32925

merged 4 commits into from May 8, 2024

Conversation

acha1os
Copy link
Contributor

@acha1os acha1os commented May 7, 2024

Description:
syslogexporter: use errors.Join instead of go.uber.org/multierr

Link to tracking Issue:
#25121

Testing:

Documentation:

@acha1os acha1os requested review from andrzej-stencel and a team as code owners May 7, 2024 17:45
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented May 7, 2024 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

@songy23 songy23 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 7, 2024
@songy23
Copy link
Member

songy23 commented May 7, 2024

Some tests need fixing https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/8989947691/job/24694777435?pr=32925

@acha1os
Copy link
Contributor Author

acha1os commented May 7, 2024

I fixed the test in exporter/syslogexporter but I'm not sure how to run the rest of them to make sure there are no more errors.

@andrzej-stencel andrzej-stencel merged commit 03ebf97 into open-telemetry:main May 8, 2024
162 checks passed
@github-actions github-actions bot added this to the next release milestone May 8, 2024
rimitchell pushed a commit to rimitchell/opentelemetry-collector-contrib that referenced this pull request May 8, 2024
@acha1os @rimitchell
[exporter/syslogexporter] use errors.Join instead of go.uber.org/mult…
2156591 
…ierr (open-telemetry#32925)

**Description:** 
syslogexporter: use errors.Join instead of go.uber.org/multierr

**Link to tracking Issue:** 

[open-telemetry#25121](open-telemetry#25121)

**Testing:** 

**Documentation:**
jlg-io pushed a commit to jlg-io/opentelemetry-collector-contrib that referenced this pull request May 14, 2024
@acha1os @jlg-io
[exporter/syslogexporter] use errors.Join instead of go.uber.org/mult…
866e36b 
…ierr (open-telemetry#32925)

**Description:** 
syslogexporter: use errors.Join instead of go.uber.org/multierr

**Link to tracking Issue:** 

[open-telemetry#25121](open-telemetry#25121)

**Testing:** 

**Documentation:**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@songy23 songy23 songy23 approved these changes

@andrzej-stencel andrzej-stencel andrzej-stencel approved these changes

@kkujawa-sumo kkujawa-sumo Awaiting requested review from kkujawa-sumo

@rnishtala-sumo rnishtala-sumo Awaiting requested review from rnishtala-sumo

Assignees

@songy23 songy23

Labels
exporter/syslog Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
next release
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@acha1os @songy23 @bogdandrutu @andrzej-stencel