Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/sentryexporter] Upgrade github.com/getsentry/sentry-go from 0.13.0 to 0.14.0 #14928

Merged

Conversation

AbhiPrasad
Copy link
Member

Originally attempted in #14796

Description:

Upgrades Sentry Go SDK by fixing a breaking change introduced with getsentry/sentry-go#444

Link to tracking Issue: Fixes #14903

Testing: Updated tests for the breaking changes, all other tests passed.

Not sure if this allows for a CHANGELOG entry - @codeboten would appreciate feedback here! (will also be down to update contributing docs to reflect this, since I couldn't find anything related to deps bumps there)

@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 14, 2022
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the skip changelog label 👍🏻

It looks like CI is failing, please take a look.

@AbhiPrasad
Copy link
Member Author

It looks like CI is failing, please take a look.

Sorry - was another go mod tidy I failed to account for. Fixed!

@codeboten
Copy link
Contributor

Thanks @AbhiPrasad!

@codeboten codeboten merged commit e3e784c into open-telemetry:main Oct 14, 2022
@AbhiPrasad AbhiPrasad deleted the sentry-upgrade-go-sdk-0.14.0 branch October 14, 2022 17:58
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update github.com/getsentry/sentry-go from 0.13.0 to 0.14.0 causes issues
3 participants