[exporter/awsxrayexporter] fixed cloudwatch log group ARN parsing #13700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 29, 2022 12:49
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
codeboten
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixed the Log group ARN parsing logic to account for another, valid log group ARN representation that includes a trailing
:*on the ARN. Before this fix, the parser would incorrectly pick up the asterisk as the log group name.Before, we used
bytesfor performance, but now that we're actually returning what we callSpliton, I think it makes more sense to usestringsinstead.Link to tracking Issue:
fixes #13702
Full discussion on open-telemetry/opentelemetry-java#4574
Testing:
Modified a unit test to cover this case.